bito-code-review[bot] commented on code in PR #38407:
URL: https://github.com/apache/superset/pull/38407#discussion_r2894951338
##########
superset/mcp_service/mcp_config.py:
##########
@@ -45,6 +45,10 @@
# MCP Debug mode - shows suppressed initialization output in stdio mode
MCP_DEBUG = False
+# MCP RBAC - when True, tools with class_permission_name are checked
+# against the FAB security_manager before execution.
+MCP_RBAC_ENABLED = True
Review Comment:
<!-- Bito Reply -->
Yes, adding `MCP_RBAC_ENABLED` to the `get_mcp_config` defaults allows users
to override the RBAC flag in `superset_config.py`, which aligns with the code's
default behavior in `auth.py` and provides configurability.
**superset/mcp_service/mcp_config.py**
```
"MCP_DEBUG": MCP_DEBUG,
"MCP_RBAC_ENABLED": MCP_RBAC_ENABLED,
**MCP_SESSION_CONFIG,
**MCP_CSRF_CONFIG,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
