bito-code-review[bot] commented on code in PR #38402:
URL: https://github.com/apache/superset/pull/38402#discussion_r2894953632
##########
superset/mcp_service/app.py:
##########
@@ -118,6 +118,10 @@ def get_default_instructions(branding: str = "Apache
Superset") -> str:
- chart_type="xy", kind="scatter": Scatter plot for correlation analysis
- chart_type="table": Data table for detailed views
- chart_type="table", viz_type="ag-grid-table": Interactive AG Grid table
+- chart_type="handlebars": Custom HTML template chart (KPI cards,
leaderboards, reports)
+ Requires handlebars_template with Handlebars HTML template string.
+ Supports query_mode="aggregate" (with metrics/groupby) or "raw" (with
columns).
+ Data available as {{{{data}}}} array; helpers: dateFormat, formatNumber,
stringify.
Review Comment:
<!-- Bito Reply -->
The four braces {{{{data}}}} are correct for Jinja2 template escaping to
display the Handlebars triple-stache {{{data}}} in the documentation. The bot's
suggestion to simplify to {{data}} would be incorrect. Your clarification to
avoid confusion is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
