richardfogaca commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2897074023
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx:
##########
@@ -142,8 +147,11 @@ export default function PluginFilterSelect(props:
PluginFilterSelectProps) {
inverseSelection,
defaultToFirstItem,
searchAllOptions,
+ operatorType = SelectFilterOperatorType.Exact,
} = formData;
+ const isLikeOperator = operatorType !== SelectFilterOperatorType.Exact;
Review Comment:
Can we restrict the new ILIKE modes to string columns? As written, any
non-Exact operator flips to text input + ILIKE/NOT ILIKE, which may not be
valid for non-text columns on all engines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
