richardfogaca commented on code in PR #38374:
URL: https://github.com/apache/superset/pull/38374#discussion_r2897928510
##########
superset-frontend/plugins/legacy-plugin-chart-map-box/src/transformProps.ts:
##########
@@ -116,5 +119,8 @@ export default function transformProps(chartProps:
ChartProps) {
pointRadiusUnit,
renderWhileDragging,
rgb,
+ viewportLongitude,
Review Comment:
I think we should normalize these before passing them through.
These controls are TextControls with `isFloat`, and they do not always emit
numbers: `''` stays `''`, and some valid float inputs such as `10.0` /
`-122.40` can remain strings. Forwarding the raw values here means MapBox can
receive string or empty viewport props and then write them directly into map
state.
Can we coerce these to finite numbers (or leave them undefined) before
returning them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
