bito-code-review[bot] commented on code in PR #36933:
URL: https://github.com/apache/superset/pull/36933#discussion_r2911110412
##########
tests/unit_tests/extensions/test_types.py:
##########
@@ -61,6 +61,18 @@ def test_extension_config_full():
"description": "A query insights extension",
"dependencies": ["other-extension"],
"permissions": ["can_read", "can_view"],
+ "frontend": {
+ "contributions": {
+ "views": {
+ "sqllab": {
+ "panels": [
+ {"id": "query_insights.main", "name": "Query
Insights"}
+ ]
+ }
+ }
+ },
+ "moduleFederation": {"exposes": ["./index"]},
+ },
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing frontend assertions</b></div>
<div id="fix">
The test validates ExtensionConfig parsing with frontend but lacks
assertions for frontend values, violating the rule to assert actual behavior
logic rather than just component rendering/parsing.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
```
--- a/tests/unit_tests/extensions/test_types.py
+++ b/tests/unit_tests/extensions/test_types.py
@@ -86,6 +86,10 @@ def test_extension_config_full():
assert config.permissions == ["can_read", "can_view"]
assert config.backend is not None
assert config.backend.files == ["backend/src/query_insights/**/*.py"]
+ assert config.frontend is not None
+ assert
config.frontend.contributions["views"]["sqllab"]["panels"][0]["id"] ==
"query_insights.main"
+ assert
config.frontend.contributions["views"]["sqllab"]["panels"][0]["name"] == "Query
Insights"
+ assert config.frontend.moduleFederation["exposes"] == ["./index"]
```
</div>
</details>
</div>
<small><i>Code Review Run #786a36</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
