richardfogaca commented on code in PR #38470:
URL: https://github.com/apache/superset/pull/38470#discussion_r2914024408
##########
superset-frontend/src/filters/components/Select/SelectFilterPlugin.test.tsx:
##########
@@ -1249,3 +1250,133 @@ test('resets dependent filter to first item when value
does not exist in data',
);
});
});
+
+test('renders text input instead of dropdown when operatorType is ILIKE
contains', () => {
+ jest.useFakeTimers();
+ const setDataMaskMock = jest.fn();
+
+ render(
+ // @ts-expect-error
Review Comment:
I see your point, but I’d rather not add more @ts-expect-error in new tests
just because the file already has some existing ones.
Can you avoid repeating that pattern here, ideally by using a small shared
helper or a single centralized cast? I’m not asking for a broader typing
refactor in this PR, only to avoid extending the suppression pattern in the new
coverage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
