msyavuz commented on code in PR #38094:
URL: https://github.com/apache/superset/pull/38094#discussion_r2917176104
##########
superset-frontend/src/visualizations/TimeTable/components/FormattedNumber/FormattedNumber.test.tsx:
##########
@@ -39,14 +39,9 @@ test('should render with thousands separator', () => {
expect(screen.getByText('1,234,567')).toBeInTheDocument();
});
-test('should render zero when num is undefined', () => {
+test('should render null when num is undefined', () => {
render(<FormattedNumber format=".2f" />);
- expect(screen.getByText('0.00')).toBeInTheDocument();
-});
-
-test('should render zero without format when num is undefined', () => {
- render(<FormattedNumber />);
- expect(screen.getByText('0')).toBeInTheDocument();
+ expect(screen.getByText('null')).toBeInTheDocument();
Review Comment:
This might be relevant right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
