rusackas commented on PR #34806: URL: https://github.com/apache/superset/pull/34806#issuecomment-4041988610
This PR hasn't been updated in a long time and has several CI failures (pre-commit, test-mysql, test-postgres, test-sqlite). The test failures are likely caused by the `.encode()` call changing the result type from `str` to `bytes`, which may break downstream callers. We'll mark it as draft for now — please investigate the test failures, fix the type issue, rebase against `master`, and set it back to 'ready for review' when it's ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
