rusackas commented on PR #28038: URL: https://github.com/apache/superset/pull/28038#issuecomment-4042077898
Adopted this PR on behalf of the original author. Changes made: - Rebased onto current master (clean rebase, no conflicts) - Added unit tests for the color threshold formatter behavior with `bigNumber === 0` (as requested in review) - All pre-commit checks pass (lint, type-checking) The fix correctly replaces the falsy check with an explicit `typeof bigNumber === 'number' && !isNaN(bigNumber)` guard, ensuring zero-value data points receive conditional color formatting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
