bito-code-review[bot] commented on code in PR #37458:
URL: https://github.com/apache/superset/pull/37458#discussion_r2921514318
##########
superset/translations/pt_BR/LC_MESSAGES/messages.po:
##########
@@ -12448,7 +12448,7 @@ msgstr "Enviar"
msgid "Subtitle"
msgstr "TÃtulo da aba"
-msgid "Subtotal"
+msgid "Subvalue"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Outdated translation for changed msgid</b></div>
<div id="fix">
The msgid changed from 'Subtotal' to 'Subvalue', but the msgstr remains
'Subtotal'. Since the code uses t('Subvalue') for pivot table subtotal labels,
the translation should be updated to match, preventing incorrect display of
'Subtotal' instead of the proper Portuguese term for 'Subvalue'.
</div>
</div>
<small><i>Code Review Run #4367f1</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/messages.pot:
##########
@@ -11076,7 +11076,7 @@ msgstr ""
msgid "Subtitle"
msgstr ""
-msgid "Subtotal"
+msgid "Subvalue"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Incorrect subtotal label</b></div>
<div id="fix">
The msgid change from "Subtotal" to "Subvalue" appears incorrect. In
client_processing.py (lines 178, 204), this string labels subtotals in pivot
tables, where code comments and variable names ('subtotal') indicate it should
be "Subtotal", not "Subvalue". This could confuse users expecting standard
terminology.
</div>
</div>
<small><i>Code Review Run #4367f1</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
