bito-code-review[bot] commented on code in PR #38608:
URL: https://github.com/apache/superset/pull/38608#discussion_r2926226411
##########
superset-frontend/packages/superset-ui-core/src/components/MetadataBar/ContentConfig.tsx:
##########
@@ -23,7 +23,7 @@ import { Icons } from '@superset-ui/core/components/Icons';
import { ContentType, MetadataType } from '.';
const Header = styled.div`
- font-weight: ${({ theme }) => theme.fontWeightStrong};
+ font-weight: bold;
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Theming Token Violation</b></div>
<div id="fix">
This change hardcodes 'bold' instead of using the theme's fontWeightStrong
token, which violates the guideline to prefer Ant Design theming tokens over
custom styles. The theme token ensures consistent bold rendering across the app
(typically 600 or higher), while 'bold' (700) may differ visually.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
font-weight: ${({ theme }) => theme.fontWeightStrong};
````
</div>
</details>
</div>
<details>
<summary><b>Citations</b></summary>
<ul>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/b0212dc/AGENTS.md#L34";>AGENTS.md:34</a>
</li>
<li>
Rule Violated: <a
href="https://github.com/apache/superset/blob/b0212dc/AGENTS.md#L35";>AGENTS.md:35</a>
</li>
</ul>
</details>
<small><i>Code Review Run #133ad7</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
