bito-code-review[bot] commented on code in PR #38606:
URL: https://github.com/apache/superset/pull/38606#discussion_r2926324401
##########
superset/config.py:
##########
@@ -311,6 +311,7 @@ def _try_json_readsha(filepath: str, length: int) -> str |
None:
"superset.views.core.explore_json",
"superset.views.core.log",
"superset.views.datasource.views.samples",
+ "flask_appbuilder.security.views.acs",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Invalid CSRF Exempt Entry</b></div>
<div id="fix">
This addition appears incorrect, as Flask-AppBuilder 5.x does not have a
security view named 'acs'. The WTF_CSRF_EXEMPT_LIST expects valid endpoint
names, and this string matches no known FAB view, potentially leaving intended
exemptions ineffective.
</div>
</div>
<small><i>Code Review Run #440e8b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
