bito-code-review[bot] commented on code in PR #38562: URL: https://github.com/apache/superset/pull/38562#discussion_r2927633746
########## pyproject.toml: ########## @@ -144,7 +144,7 @@ solr = ["sqlalchemy-solr >= 0.2.0"] elasticsearch = ["elasticsearch-dbapi>=0.2.12, <0.3.0"] exasol = ["sqlalchemy-exasol >= 2.4.0, <3.0"] excel = ["xlrd>=1.2.0, <1.3"] -fastmcp = ["fastmcp==2.14.3"] +fastmcp = ["fastmcp>=3.1.0,<4.0"] Review Comment: <div> <div id="suggestion"> <div id="issue"><b>Dependency Breaking Change Risk</b></div> <div id="fix"> Updating fastmcp from 2.14.3 to >=3.1.0 introduces breaking changes in v3, such as decorators returning functions instead of objects, async state methods (get_state/set_state), and auth requiring explicit configuration. The MCP service uses @mcp.tool decorators and may expect v2 behavior. This could break the service at runtime. Test thoroughly or ensure code compatibility before merging. </div> </div> <small><i>Code Review Run #267335</i></small> </div> --- Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>) - [ ] Yes, avoid them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
