dpgaspar commented on code in PR #38606:
URL: https://github.com/apache/superset/pull/38606#discussion_r2929912291


##########
superset/config.py:
##########
@@ -311,6 +311,7 @@ def _try_json_readsha(filepath: str, length: int) -> str | 
None:
     "superset.views.core.explore_json",
     "superset.views.core.log",
     "superset.views.datasource.views.samples",
+    "flask_appbuilder.security.views.acs",

Review Comment:
   This view is called by the SAML IdP, the IdP can't send a POST with a CSRF. 
The other views from FAB are used by a user directly and should be protected



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to