aminghadersohi commented on PR #38403:
URL: https://github.com/apache/superset/pull/38403#issuecomment-4054520603
@sadpandajoe Thanks for the thorough review! Both items have been addressed:
1. **`_resolve_viz_type` inconsistency** — Fixed. `_resolve_viz_type` now
checks both `show_trendline` and `temporal_column` (see
chart_utils.py:1058-1063):
```python
elif chart_type == "big_number":
show_trendline = getattr(config, "show_trendline", False)
temporal_column = getattr(config, "temporal_column", None)
return (
"big_number" if show_trendline and temporal_column else
"big_number_total"
)
```
2. **`header_only` field** — Removed entirely. It was derivable and
confusing as you noted. The viz_type is now determined exclusively by
`show_trendline` + `temporal_column`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
