joaopedroab commented on PR #38374:
URL: https://github.com/apache/superset/pull/38374#issuecomment-4056237481
@richardfogaca
Thanks for the review. I addressed the residual `fitBounds` issue in
`e122e1e13d`.
The `MapBox` component now recomputes `fitBounds` when `bounds` or chart
size changes and no explicit viewport props are set, instead of keeping stale
viewport state. I also added focused tests covering:
- bounds changes with no explicit viewport
- chart size changes with no explicit viewport
- explicit viewport continuing to take precedence over `fitBounds`
The backward-compatibility concern about legacy persisted viewport
defaults remains acknowledged and documented in `UPDATING.md`.
We could handle that with a migration or a compatibility guard, but that
adds more complexity and starts to push this PR beyond its scope. In practice,
once a user updates the chart once and clears or adjusts the viewport
fields as needed, the issue is resolved going forward.
I did not add a compatibility guard for the historical San Francisco
triple because that would also override charts intentionally saved at those
exact coordinates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
