michaelmorera-preset commented on PR #38644:
URL: https://github.com/apache/superset/pull/38644#issuecomment-4067191493
The testing for Theme mode was completed. The application is working as
expected.
# Scenario
Verify the embedded dashboard is changing from dark to light (and
vice-versa) mode based on user system appearance preferences.
| Variant | Status |
| -------- | -------- |
| embedded - from dark to light | :white_check_mark: |
| embedded - from light to dark | :white_check_mark: |
| embedded - from system pref | :white_check_mark: |
| not embedded superset follows the systems pref | :white_check_mark: |
## Steps
1. Set your OS to dark/light mode
2. Load an embedded dashboard (via the Superset Embedded SDK)
3. Call `setThemeMode('dark')` via the SDK
4. Call `setThemeMode('system')` via the SDK
### Actual result:
After the step 2, the dashboard renders in **light/dark mode** by default
(as the set on the step 1).
After the step 4, it switches to dark mode.
After the step 5, it follows OS preference.
Non-embedded Superset still follows system theme preference
### Evidence:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
