alexandrusoare opened a new pull request, #38676:
URL: https://github.com/apache/superset/pull/38676

   ### SUMMARY
   
   - Add warning when `_generate_native_filter()` encounters an unrecognized 
filter type
   - Surface the warning in the report execution log so users are aware filters 
were skipped
   - Builds on #38272 which introduced the warning collection infrastructure
   
   #### Changes
   - Modified `_generate_native_filter()` to return a tuple `(filter_config, 
warning)` instead of just `filter_config`
   - When an unknown filter type is encountered, returns empty dict with a 
warning message
   - Updated `get_native_filters_params()` to collect warnings from 
`_generate_native_filter()`
   - Added tests for unknown filter type handling
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   <!--- Required! What steps can be taken to manually verify the changes? -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to