bito-code-review[bot] commented on code in PR #38568:
URL: https://github.com/apache/superset/pull/38568#discussion_r2940526483
##########
superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/utils.ts:
##########
@@ -27,6 +27,24 @@ import { FILTER_SUPPORTED_TYPES } from './constants';
const FILTERS_FIELD_NAME = 'filters';
+type TimeGrainTuple = [string, string];
+type TimeGrainObject = { value: string; label?: string };
+
+export const getTimeGrainOptions = (
+ timeGrains: Array<TimeGrainTuple | TimeGrainObject> = [],
+) =>
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing return type annotation</b></div>
<div id="fix">
The exported function getTimeGrainOptions lacks an explicit return type
annotation, which improves code maintainability and type safety. Consider
adding the return type to align with TypeScript best practices.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
export const getTimeGrainOptions = (
timeGrains: Array<TimeGrainTuple | TimeGrainObject> = [],
): Array<{ value: string; label: string }> =>
````
</div>
</details>
</div>
<small><i>Code Review Run #4731b4</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
