bito-code-review[bot] commented on code in PR #37396:
URL: https://github.com/apache/superset/pull/37396#discussion_r2955680972
##########
tests/integration_tests/utils_tests.py:
##########
@@ -497,3 +498,60 @@ def normalize_col(
# test numeric epoch_ms format
df = pd.DataFrame([{"__timestamp": ts.timestamp() * 1000, "a": 1}])
assert normalize_col(df, "epoch_ms", 0, None)[DTTM_ALIAS][0] == ts
+
+
[email protected]("load_birth_names_dashboard_with_slices")
+class TestExtractDisplayLabels:
+ def get_slice(self, slice_name: str) -> Slice:
+ return db.session.query(Slice).filter_by(slice_name=slice_name).one()
+
+ @pytest.mark.parametrize(
+ "label_map, colnames, expected",
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Wrong type for parametrize names argument</b></div>
<div id="fix">
Change the `pytest.mark.parametrize` names argument from a string to a
tuple. Use `("label_map", "colnames", "expected")` instead of the current
string format.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
@pytest.mark.parametrize(
("label_map", "colnames", "expected"),
````
</div>
</details>
</div>
<small><i>Code Review Run #d0766e</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
