rusackas commented on PR #38035: URL: https://github.com/apache/superset/pull/38035#issuecomment-4085637888
This is looking great! Love the dark maps... it's just so pretty. <img width="811" height="531" alt="image" src="https://github.com/user-attachments/assets/abb46622-b4c4-4a35-af9f-e7c48d3865a9"; /> I've tested: • DeckGL Examples actually WORK now by default (showing tiles) • Building a new point cluster map works great • Switching to MapBox is supported (though the showtime server doesn't have a credential to test they _work_) Some questions/discussion items: • The migration seems to convert all DeckGL charts to use MapLibre. Since there's feature parity (and it's arguably nicer and more open-source) I'm _personally_ fine with that. I wonder if anyone has _any_ reason to worry about this migration taking place on their charts/dashboards. • When selecting MapBox tiles, and there's no API key, it shows a text blurb about needing the API key. I *think* that's fine so long as someone tests it WITH the API key inserted. • Check my sanity here, but when the old charts were rendered without a MapBox API key, they'd show the deckGL layer, but not the tiles. I'm not sure if that changed with this PR which _only_ shows the text. Personally, I'm OK with that (they looked broken/useless as it was), but this _might_ be considered a minor breaking change to some (not me, really). I think the migration is the only real "maybe" here with a debate about running the migration on _all_ pre-existing charts (I'm on board with it!) vs leaving existing ones as-is, and making MapLibre the new default selection for new charts. The latter means we have a chore of updating examples, and _could_ do an opt-in migration like we did once upon a time for _ye olde_ Filter Boxes. Curious what @villebro @michael-s-molina @jansule @mistercrunch @DamianPendrak @sadpandajoe @eschutho feel about all of the above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
