michaelmorera-preset commented on PR #38517:
URL: https://github.com/apache/superset/pull/38517#issuecomment-4088648557
The testing for this ticket was completed. The application is working as
expected. Ant design is working correctly when the user uses the primary color
changed.
Scenario
Verify that all links follow the primary color palette instead of appearing
teal/green. (default)
## Steps
1)Open the Ant Design Theme Builder.
2)Set the Primary Color to a custom color (e.g., #eb2f96).
3)Export the theme config
4)Apply this configuration as a Superset theme.
5)Navigate to pages containing links (e.g., dashboards list, charts list).
## Expected
- Links follow the primary color palette instead of appearing teal/green.
:white_check_mark:
- Explicitly setting colorLink in the theme config still overrides the
derived value. :white_check_mark:
- If we choose to "inherit" link and info color in ant design theme builder,
it should be respected. :white_check_mark:
## Ant Design JSON - Just Primary
> {
> "token": {
> "colorPrimary": "#eb2f96"
> },
> "algorithm": "default"
> }
## Ant Design JSON - Color Link
> {
> "token":{
> "colorPrimary": "#ec4899",
> "colorLink": "#ff0000"
> }
> }
## Evidence
Ant design primary color testing
<img width="1913" height="1003" alt="Ant design primary color testing"
src="https://github.com/user-attachments/assets/27474738-c94a-4559-9394-20e404169db5";
/>
Color link theme testing
<img width="1913" height="1003" alt="Color Link Theme testing"
src="https://github.com/user-attachments/assets/7b8cb55f-0e5b-4a49-8f8f-43e8b3789ed4";
/>
Ant design theme editor testing primary color
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
