alexandrusoare opened a new pull request, #38742: URL: https://github.com/apache/superset/pull/38742
### SUMMARY When using Firebolt in Superset, queries with SELECT * EXCLUDE (column) syntax would fail because SQLGlot was incorrectly transforming the EXCLUDE keyword to EXCEPT before sending the query to Firebolt, which only supports EXCLUDE. **Root Cause:** The Superset Firebolt SQLGlot dialect was using the default `STAR_EXCEPT = "EXCEPT"` from the base Generator class, but Firebolt actually uses `EXCLUDE` syntax (like DuckDB and Snowflake). **Fix:** Added `STAR_EXCEPT = "EXCLUDE"` to the Firebolt Generator class in `superset/sql/dialects/firebolt.py` ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF #### BEFORE https://github.com/user-attachments/assets/6daed08d-bd41-4a23-9ec1-d5cdb77017b7 #### AFTER https://github.com/user-attachments/assets/cab19292-e90f-4f79-aa18-925201a94518 ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
