MDeadman commented on PR #38638: URL: https://github.com/apache/superset/pull/38638#issuecomment-4091419727
Forgot to comment yesterday: I have shipped one more commit. I unskipped the test with the fixture codeant is claiming to be problematic, as it runs fine locally for me. I will see if it passes in CI and if not that I will re-add the skip. I decided to go with the dict merging approach for handling custom_form_data, as that is what is most aligned with the behaviour elsewhere in the code base. I also saw in the CI run the integration tests failed from a bug with API Spec for the API docs, so I made some changes which should resolve that issue and get CI working. Just updated the branch, I will check in again later today to make sure CI is passing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
