shivamgoel commented on code in PR #37815: URL: https://github.com/apache/superset/pull/37815#discussion_r2979393882
########## superset/semantic_layers/registry.py: ########## @@ -0,0 +1,24 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from typing import Any + +from superset_core.semantic_layers.layer import SemanticLayer + +registry: dict[str, type[SemanticLayer[Any, Any]]] = {} Review Comment: The registry starts empty -- all semantic layers (Snowflake, dbt, etc.) are installed as extensions. Meanwhile, datasets/tables follow a completely separate code path (BaseDatasource.query() -> SQLAlchemy SQL generation) that doesn't go through SemanticQuery or the mapper at all. ▎ This means Superset has two fundamentally different query architectures side by side: ▎ - Datasets: QueryObject -> SQL (via SqlaTable.query()) ▎ - Semantic views: QueryObject -> SemanticQuery (via mapper) -> external provider Should Datasets just be one built-in Semantic Layer option ? This would probably mean creating a built-in SqlSemanticLayer that wraps SqlaTable.query() behind the SemanticLayer/SemanticView -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
