richardfogaca commented on code in PR #38675: URL: https://github.com/apache/superset/pull/38675#discussion_r2983364091
########## superset-frontend/plugins/plugin-chart-echarts/lib/utils/legendLayout.d.ts: ########## @@ -0,0 +1,42 @@ +/** Review Comment: Good point. I took another look and I don’t think this should be moved to /types; the real issue is that this was a generated lib artifact that should not have been introduced into the PR in the first place, especially since superset-frontend/.gitignore ignores **/lib/*. I removed lib/utils/legendLayout.d.ts -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
