aminghadersohi commented on PR #38859: URL: https://github.com/apache/superset/pull/38859#issuecomment-4133621006
Addressing review comments — all squashed into single commit 172131ce30: **Re: codeant bot concern about `_make_mock_chart()` and `type(chart).tags = property(...)`:** This is incorrect — `Mock.__setattr__` bypasses the descriptor protocol, so setting a property on `type(chart)` does not prevent instance attribute assignment on other Mock instances. All 955 MCP tests pass. **Re: "i am looking into a better solution" (stale session fallback):** Resolved. On re-fetch failure, we now return a minimal response using only scalar attributes (id, title, url) that are already loaded on the object — no lazy-loaded relationships (owners, tags, slices) are accessed. This follows the `update_chart.py` pattern (lines 238-270) which builds its response from scalar attributes without any re-fetch. **All prior review comments** (rollback, import ordering, test coverage) were addressed in earlier commits and are now squashed into this single commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
