aminghadersohi commented on PR #38934: URL: https://github.com/apache/superset/pull/38934#issuecomment-4154754851
Thanks for the thorough review @kgabryje — both issues were spot on. Fixed in 16f016330f: **1. GRID_ID regression on tabbed dashboards** — Restored the `has_tabs_under_root` guard in `_ensure_layout_structure` and all 5 regression tests. This was a merge artifact — the PR branch was based before #38890 landed, and the conflict resolution incorrectly dropped the guard. **2. `_ensure_session_cleanup()` in `finally`** — Removed `_ensure_session_cleanup()` and both `finally` blocks entirely. You're right that this re-introduces the pattern removed in #37548. The tool-level rollbacks in the `except` blocks (the actual fix for PendingRollbackError from SSL drops) are kept — those are the correct layer to handle poisoned sessions when tools catch exceptions and return error responses instead of re-raising. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
