sha174n opened a new pull request, #38952:
URL: https://github.com/apache/superset/pull/38952
### SUMMARY
`SqlExecutionResultsCommand.validate()` now calls
`self._query.raise_for_access()`
before fetching from the results backend, matching the pattern already
present in
`SqlResultExportCommand` and `StreamingSqlResultExportCommand`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
### TESTING INSTRUCTIONS
1. Start Superset with a results backend configured (e.g. `FileSystemCache`)
2. As an admin user, run an async SQL query against a table — note the
`results_key`
3. As a user without access to that table, call:
`GET /api/v1/sqllab/results/?q=(key:'<results_key>')`
4. Before: HTTP 200
After: HTTP 403
### ADDITIONAL INFORMATION
- [x] Has associated issue: Fixes #38908
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
