dosubot[bot] commented on issue #38982: URL: https://github.com/apache/superset/issues/38982#issuecomment-4164058113
<!-- Answer --> This is a known regression caused by a **CSS selector mismatch** after the Ant Design v5 migration. The `StyledDatasourceModal` targets Bootstrap-era class names (`.modal-content`, `.modal-body`, `.modal-footer`) but the underlying `Modal` component now emits Ant Design v5 class names (`.ant-modal-content`, `.ant-modal-body`, `.ant-modal-footer`) [[1]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Datasource/DatasourceModal.tsx#L45-L68). This means the intended `height: 900px` and flex layout overrides are **never applied**, causing: 1. **Modal taking all vertical space / hidden buttons** — the body has no constrained height, so the footer gets pushed off-screen. 2. **Tabs with no padding** — the flex chain from modal body → `DatasourceContainer` → `StyledTableTabs` → tab content is broken, so tab panes can't resolve their heights properly [[2]](https://github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Datasource/DatasourceEditor.jsx#L108-L113). [PR #38123](https://github.com/apache/superset/pull/38123) (merged 2026-02-20) identified and fixed exactly this root cause for the Folders tab by updating selectors to `&& .ant-modal-content` / `&& .ant-modal-body` and establishing a complete flex chain [[3]](https://github.com/apache/superset/pull/38123). That same approach should resolve both of the symptoms you're seeing. It's worth checking whether the fix from that PR is present in the build you're running — if you're on a commit before that merge, upgrading should resolve it. There's also a related discussion in [#38215](https://github.com/apache/superset/issues/38215) about increasing the modal to ~90% of screen space for better usability [[4]](https://github.com/apache/superset/issues/38215). <!-- Dosu Comment Footer --> *To reply, just mention [@dosu](https://go.dosu.dev/dosubot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=brand-link).* --- <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/052ca256-1c3c-4d16-946a-dd749cbb4b89?feedback_type=great_response&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/052ca256-1c3c-4d16-946a-dd749cbb4b89?feedback_type=irrelevant_answer&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/052ca256-1c3c-4d16-946a-dd749cbb4b89?feedback_type=incorrect_sources&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/052ca256-1c3c-4d16-946a-dd749cbb4b89?feedback_type=too_verbose&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/052ca256-1c3c -4d16-946a-dd749cbb4b89?feedback_type=hallucination&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/052ca256-1c3c-4d16-946a-dd749cbb4b89?feedback_type=bug_report&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-bug_report) | [Other](https://app.dosu.dev/response-feedback/052ca256-1c3c-4d16-946a-dd749cbb4b89?feedback_type=other&utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=feedback-other)</sup> [](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=chat-badge) [](https://cursor.com/link/prompt?text=This%20is%20a%20known%20regression%20caused%20by%20a%20%2A%2ACSS%20selector%20mismatch%2A%2A%20after%20the%20Ant%20Design%20v5%20migration.%20The%20%60StyledDatasourceModal%60%20targets%20Bootstrap-era%20class%20names%20%28%60.modal-content%60%2C%20%60.modal-body%60%2C%20%60.modal-footer%60%29%20but%20the%20underlying%20%60Modal%60%20component%20now%20emits%20Ant%20Design%20v5%20class%20names%20%28%60.ant-modal-content%60%2C%20%60.ant-modal-body%60%2C%20%60.ant-modal-footer%60%29%20%5B%5B1%5D%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Datasource/DatasourceModal.tsx%23L45-L68%29.%20This%20means%20t he%20intended%20%60height%3A%20900px%60%20and%20flex%20layout%20overrides%20are%20%2A%2Anever%20applied%2A%2A%2C%20causing%3A%0A%0A1.%20%2A%2AModal%20taking%20all%20vertical%20space%20/%20hidden%20buttons%2A%2A%20%E2%80%94%20the%20body%20has%20no%20constrained%20height%2C%20so%20the%20footer%20gets%20pushed%20off-screen.%0A2.%20%2A%2ATabs%20with%20no%20padding%2A%2A%20%E2%80%94%20the%20flex%20chain%20from%20modal%20body%20%E2%86%92%20%60DatasourceContainer%60%20%E2%86%92%20%60StyledTableTabs%60%20%E2%86%92%20tab%20content%20is%20broken%2C%20so%20tab%20panes%20can%27t%20resolve%20their%20heights%20properly%20%5B%5B2%5D%5D%28https%3A//github.com/apache/superset/blob/829e4d92d91ceae4b43b1ed3b063ffe45377799c/superset-frontend/src/components/Datasource/DatasourceEditor.jsx%23L108-L113%29.%0A%0A%5BPR%20%2338123%5D%28https%3A//github.com/apache/superset/pull/38123%29%20%28merged%202026-02-20%29%20identified%20and%20fixed%20exactly%20this%20root%20cause%20for%20the%20Folders%20tab%20by%20up dating%20selectors%20to%20%60%26amp%3B%26amp%3B%20.ant-modal-content%60%20/%20%60%26amp%3B%26amp%3B%20.ant-modal-body%60%20and%20establishing%20a%20complete%20flex%20chain%20%5B%5B3%5D%5D%28https%3A//github.com/apache/superset/pull/38123%29.%20That%20same%20approach%20should%20resolve%20both%20of%20the%20symptoms%20you%27re%20seeing.%20It%27s%20worth%20checking%20whether%20the%20fix%20from%20that%20PR%20is%20present%20in%20the%20build%20you%27re%20running%20%E2%80%94%20if%20you%27re%20on%20a%20commit%20before%20that%20merge%2C%20upgrading%20should%20resolve%20it.%0A%0AThere%27s%20also%20a%20related%20discussion%20in%20%5B%2338215%5D%28https%3A//github.com/apache/superset/issues/38215%29%20about%20increasing%20the%20modal%20to%20~90%25%20of%20screen%20space%20for%20better%20usability%20%5B%5B4%5D%5D%28https%3A//github.com/apache/superset/issues/38215%29.) [](https://go.dosu.dev/discord-b ot?utm_source=github&utm_medium=bot-comment&utm_campaign=github-assistant&utm_content=join-discord) [](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/38982) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
