justinpark commented on code in PR #38563:
URL: https://github.com/apache/superset/pull/38563#discussion_r3017138474
##########
superset-frontend/packages/superset-ui-core/src/components/TableView/TableView.tsx:
##########
@@ -117,43 +117,45 @@ const RawTableView = ({
...props
}: TableViewProps) => {
const tableRef = useRef<HTMLTableElement>(null);
+ const effectivePageSize = initialPageSize ?? DEFAULT_PAGE_SIZE;
Review Comment:
Personally, I think it would be better to exclude this file's changes, as
they are not related to the React 18 upgrade
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
