etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r318842584
########## File path: superset/connectors/base/models.py ########## @@ -154,11 +154,11 @@ def short_data(self): } @property - def select_star(self): + def select_star(self) -> str: Review comment: This should be `Optional[str]` right? if not then it should probably raise a `NotImplementedError()` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org