etr2460 commented on a change in pull request #8139: [sqllab] add retries for
stop_query
URL:
https://github.com/apache/incubator-superset/pull/8139#discussion_r320374368
##########
File path: superset/views/core.py
##########
@@ -2430,14 +2432,30 @@ def results(self, key):
@has_access_api
@expose("/stop_query/", methods=["POST"])
@event_logger.log_this
+ @backoff.on_exception(
+ backoff.constant,
+ DatabaseError,
Review comment:
This will now throw and return a 500 when there's an exception other than a
DatabaseError, correct? I think that is an improvement to the generic Exception
catching before, but wanted to make sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
