villebro opened a new pull request #8165: [bugfix] fix timegrain addon regression URL: https://github.com/apache/incubator-superset/pull/8165 ### CATEGORY - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [x] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY Custom timegrains defined in `superset_config.py` stopped working between 0.32 and 0.34. This fixes the regression and renames some functions and variables to more clearly indicate what is public and private. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN Local testing + CI ### ADDITIONAL INFORMATION - [ ] Has associated issue: #8162 - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS @lilila @mistercrunch
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org