betodealmeida commented on a change in pull request #8060: SIP-23: Persist SQL
Lab state in the backend
URL:
https://github.com/apache/incubator-superset/pull/8060#discussion_r320987634
##########
File path: superset/assets/src/SqlLab/actions/sqlLab.js
##########
@@ -132,7 +139,23 @@ export function startQuery(query) {
}
export function querySuccess(query, results) {
- return { type: QUERY_SUCCESS, query, results };
+ return function (dispatch) {
+ // table preview queries have `sqlEditorId` set to the string 'null'; those
Review comment:
It will be always true, but I agree have it explicit is better, will fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
