Copilot commented on code in PR #39468:
URL: https://github.com/apache/superset/pull/39468#discussion_r3190579940
##########
superset-frontend/plugins/preset-chart-deckgl/src/utils/colors.ts:
##########
@@ -16,7 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
-import { rgb } from 'd3-color';
+import tinycolor from 'tinycolor2';
Review Comment:
This file now imports `tinycolor2`, but
`superset-frontend/plugins/preset-chart-deckgl/package.json` removes `d3-color`
without adding `tinycolor2` as a direct dependency. The package may still build
in a hoisted monorepo, but published/isolated installs of this plugin will fail
module resolution because the imported package is undeclared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
