bito-code-review[bot] commented on PR #39984:
URL: https://github.com/apache/superset/pull/39984#issuecomment-4411004729
<!-- Bito Reply -->
The flagged issue is correct - the test now fails because the initial page
load already sorts by 'changed_on_delta_humanized', so clicking the header
creates a second matching request. To fix this, change the assertion to check
the latest call instead of expecting exactly one call.
**superset-frontend/src/pages/ChartList/ChartList.listview.test.tsx**
```
const lastModifiedSortCalls = dataCalls
.filter(
call =>
call.url.includes('order_column') &&
call.url.includes('changed_on_delta_humanized'),
);
const lastCall = lastModifiedSortCalls[lastModifiedSortCalls.length -
1];
expect(lastCall.url).toContain('order_column=changed_on_delta_humanized');
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
