rusackas commented on PR #39683: URL: https://github.com/apache/superset/pull/39683#issuecomment-4432952896
Looking good to me! Kicking off CI, and planning to spin up a test env. Upon review it looks like the NO_TIME_RANGE fallback change is a subtle breaking behavior change. When BASE_AXIS is set but no matching filter exists, the old code would silently fall back to the first temporal filter's range. The new code returns NO_TIME_RANGE, resulting in an unbounded query. It's arguably more correct, but it will visibly affect existing dashboards where the old behavior happened to work. There should at minimum be a note in the description, and ideally this should be called out in an UPDATING.md entry. Adding @sadpandajoe, since this is something we'll definitely want to test thoroughly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
