Mayankaggarwal8055 commented on PR #39782: URL: https://github.com/apache/superset/pull/39782#issuecomment-4433274977
Thanks for the explanation @rusackas — that clears it up a lot. I didn’t think about the fact that the updated test was no longer covering the actual production path with naive datetimes. Keeping the test behavior aligned with real usage definitely makes more sense here. Combining both approaches sounds like the best fix: * handling naive datetimes consistently in the implementation * while still keeping the tests focused on the real input scenario I also noticed the failing `pre-commit` check. I’ll try running things locally too and see if I can spot anything. Been enjoying following these timezone and dashboard issues lately — there are a lot of subtle edge cases in Superset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
