rusackas commented on PR #38449: URL: https://github.com/apache/superset/pull/38449#issuecomment-4434290746
@sadpandajoe Good catch, here's the breakdown: - **`tests/integration_tests/tasks/test_cache.py`** tested `fetch_url()` in `superset/tasks/cache.py`. That function is **gone** in this PR — the WebDriver flow replaces `urllib.request`-based URL fetching entirely (the dashboard is rendered through a real authenticated browser session, no manual CSRF dance). So the test is correctly removed along with the function it was testing. - **`tests/integration_tests/tasks/test_utils.py`** tested `fetch_csrf_token()` in `superset/tasks/utils.py`. The **function still exists** in `utils.py` in this PR — only its sole internal caller (`fetch_url`) was removed. I'll restore the test in the next push since the function is still part of the codebase / potentially public surface. (Open question for a follow-up: whether `fetch_csrf_token` should also be removed once we're confident nothing external relies on it — but that's a deprecation conversation, not this PR.) While digging in I also noticed this branch needs a non-trivial rebase: `superset/tasks/cache.py` has changed substantially on master since this PR was opened — `DashboardTagsStrategy.get_urls()` / `cache_warmup`'s URL-based dispatch has been refactored to a chart-level `get_tasks()` model. Reconciling the WebDriver-auth approach with master's per-chart task dispatch is more than a mechanical merge; want to flag it before doing the architecture call myself. I'll plan to rebase + restore the `test_fetch_csrf_token` file in the next push once the cache.py reconciliation direction is settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
