amaannawab923 commented on PR #39524:
URL: https://github.com/apache/superset/pull/39524#issuecomment-4434642261
Sorry for the delay, @rusackas. The filterable filter in mapStateToProps is
legacy from pre-monorepo days (back when chart plugins lived in their own
superset-ui repo) it incorrectly conflated "filterable" with "usable as a
metric/dimension." AG Grid likely inherited it because it was built on top of
the Table plugin.
Fix is correct , LGTM to merge once rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
