bito-code-review[bot] commented on PR #40077:
URL: https://github.com/apache/superset/pull/40077#issuecomment-4435634506
<!-- Bito Reply -->
Yes, the suggestion is valid — converting Pydantic preview models to plain
data via `model_dump()` ensures consistent JSON serialization and aligns with
other response-building paths that explicitly serialize models.
**superset/mcp_service/chart/tool/update_chart_preview.py**
```
else:
previews[format_type] =
preview_result.model_dump()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
