rusackas commented on code in PR #40102: URL: https://github.com/apache/superset/pull/40102#discussion_r3238696744
########## docs/developer_docs/extensions/extension-points/editors.md: ########## @@ -217,6 +217,6 @@ const disposable = handle.registerCompletionProvider(provider); ## Next Steps -- **[SQL Lab Extension Points](./sqllab)** - Learn about other SQL Lab customizations +- **[SQL Lab Extension Points](./sqllab.md)** - Learn about other SQL Lab customizations - **[Contribution Types](../contribution-types)** - Explore other contribution types - **[Development](../development)** - Set up your development environment Review Comment: Good catch — fixed in 7feff5a, plus the systemic gap that let this through CI. **What CI was missing.** `onBrokenLinks: 'throw'` only validates *file-based* references (`.md` / `.mdx`). Bare relative URLs like `[Foo](../foo)` skip the file resolver and get emitted as raw hrefs that the browser resolves against the current page URL — wrong directory for trailing-slash routes, instant 404 on SPA nav. The `linkinator` job in the docs workflow can catch these but is set `continue-on-error: true`, so the finding is advisory. **What's in the commit.** 1. Fixed the two stragglers on `editors.md` you flagged. While there, swept the rest of the PR's modified files and the broader `developer_docs` tree — found 76 of the same pattern total (14 in PR-modified files including the two here, 62 in unchanged files). All 76 targets resolved to real files, so the fix is uniformly "append `.md`". Anchors / query strings preserved. 2. Patched the component-page generator (`generate-superset-components.mjs`). 54 of the 76 lived in two auto-generated index files; without fixing the generator the next regeneration would silently undo the manual edits. 3. Added `docs/scripts/lint-docs-links.mjs` — fast source-level linter that scans `.md` / `.mdx` files under active content trees (skipping `versioned_docs/`), classifies link URLs as `doc-with-ext` / `asset` / `bare`, and exits 1 on any bare relative internal link. Excludes fenced code blocks and asset-style targets (.png/.json/etc.). 4. Wired it into `superset-docs-verify.yml` as a blocking `Lint docs links` step ahead of the build, so future regressions fail in seconds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
