bito-code-review[bot] commented on PR #40127:
URL: https://github.com/apache/superset/pull/40127#issuecomment-4455071815

   <!-- Bito Reply -->
   The flagged issue is valid: the `target_tab` description and error message 
instruct users to use `get_dashboard_info` for tab discovery, but the 
`DashboardInfo` schema doesn't expose tab IDs or names, breaking the intended 
workflow.
   
   **superset/mcp_service/dashboard/schemas.py**
   ```
   class DashboardInfo(BaseModel):
       # ... existing fields ...
       tabs: list[dict[str, str]] = Field(
           default_factory=list,
           description="List of available tabs, each as {'id': str, 'name': 
str}"
       )
       omitted_fields: list[str] = Field(
           default_factory=lambda: ["position_json"],
           description="Fields omitted from this response"
       )
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to