codecov[bot] commented on PR #40130: URL: https://github.com/apache/superset/pull/40130#issuecomment-4455190636
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40130?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report :x: Patch coverage is `54.01786%` with `103 lines` in your changes missing coverage. Please review. :white_check_mark: Project coverage is 55.90%. Comparing base ([`823eb90`](https://app.codecov.io/gh/apache/superset/commit/823eb905d3f4e1b2444ffbbebe4e7a74673903e1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`fefb486`](https://app.codecov.io/gh/apache/superset/commit/fefb486d51495e2fc1ed6f0a3f7a9e517c52dc46?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)). :warning: Report is 9 commits behind head on master. | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/40130?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [superset/views/filters.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fviews%2Ffilters.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvZmlsdGVycy5weQ==) | 42.30% | [30 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/models/helpers.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fmodels%2Fhelpers.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=) | 68.96% | [15 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/commands/restore.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fcommands%2Frestore.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvcmVzdG9yZS5weQ==) | 50.00% | [16 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/daos/base.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fdaos%2Fbase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy9iYXNlLnB5) | 28.57% | [15 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/datasets/api.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fdatasets%2Fapi.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | 50.00% | [10 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/commands/dataset/importers/v1/utils.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fcommands%2Fdataset%2Fimporters%2Fv1%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvZGF0YXNldC9pbXBvcnRlcnMvdjEvdXRpbHMucHk=) | 0.00% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/commands/importers/v1/utils.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fcommands%2Fimporters%2Fv1%2Futils.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | 50.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/daos/database.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fdaos%2Fdatabase.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvZGFvcy9kYXRhYmFzZS5weQ==) | 33.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Fsecurity%2Fmanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | 0.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/initialization/\_\_init\_\_.py](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&filepath=superset%2Finitialization%2F__init__.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvaW5pdGlhbGl6YXRpb24vX19pbml0X18ucHk=) | 85.71% | [0 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/40130?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | > :exclamation: There is a different number of reports uploaded between BASE (823eb90) and HEAD (fefb486). Click for more details. > > <details><summary>HEAD has 39 uploads less than BASE</summary> > >| Flag | BASE (823eb90) | HEAD (fefb486) | >|------|------|------| >|hive|3|1| >|python|30|3| >|presto|3|1| >|unit|9|1| ></details> <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #40130 +/- ## ========================================== - Coverage 64.15% 55.90% -8.25% ========================================== Files 2590 2592 +2 Lines 138104 138295 +191 Branches 32039 32060 +21 ========================================== - Hits 88594 77316 -11278 - Misses 47989 60313 +12324 + Partials 1521 666 -855 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.52% <54.01%> (+0.08%)` | :arrow_up: | | [mysql](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [postgres](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.20% <54.01%> (+0.08%)` | :arrow_up: | | [python](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `42.46% <54.01%> (-18.19%)` | :arrow_down: | | [sqlite](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [unit](https://app.codecov.io/gh/apache/superset/pull/40130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40130?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). <details><summary> :rocket: New features to boost your workflow: </summary> - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems. - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges. </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
