eschutho commented on PR #39895: URL: https://github.com/apache/superset/pull/39895#issuecomment-4455938084
Hey @richardfogaca — Elizabeth has addressed your feedback and wanted to flag the key changes since your last review: - The global spinner wait has been moved out of the pre-branch position and into the **non-tiled screenshot path only**, so the tiled path (which already has per-tile viewport checks) no longer runs a redundant pre-check. - The non-tiled path now correctly waits for all spinners, including below-fold content. Would you be able to take another look when you get a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
