venkatamandavilli-code commented on PR #36214: URL: https://github.com/apache/superset/pull/36214#issuecomment-4461722147
Thanks for working on this fix. The issue makes sense, especially for numeric-like string dimensions where lexicographic ordering can make timeseries charts visually misleading. One area I’d suggest double-checking is the sorting logic in `transformProps.ts`. Since the current approach sorts the series data, it may be safer to avoid mutating the original data array in place and instead sort a copied array. It may also be worth skipping annotation-related series such as `markLine` or `markArea`, since those may have their own ordering/structure. For temporal axes, I’d also consider normalizing the fallback value when date parsing fails so the comparison does not mix numbers and strings. Returning a consistent numeric fallback, such as sorting invalid dates last, would make the behavior more predictable. Overall, the fix looks useful, but these small safeguards could reduce side effects for larger charts or mixed series configurations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
