Elengar commented on PR #40180: URL: https://github.com/apache/superset/pull/40180#issuecomment-4467067275
> ### Code Review Agent Run #7d3468 @bito-code-review `getCrossFilterValue` is private, so I believe testing the emitted cross-filter payload should be enough. For `role="columnheader button"`: this was removed by `oxlint --fix`. The combined role is not valid additive ARIA, and the table header already has implicit `columnheader` semantics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
