alex-poor commented on PR #39906: URL: https://github.com/apache/superset/pull/39906#issuecomment-4472400646
@DamianPendrak addressed your review in 6feaa03 — replaced both `console.warn` + legacy-fallback blocks with `throw new Error(...)`, matching the file's existing pattern for misconfigurations. If `cross_filter_column` is configured but the value isn't present on the picked feature (e.g. a stale-cached chart that was saved before the column was added to the query), the click now produces no filter at all rather than silently emitting a broken one — the user can re-save the chart to refresh. When `cross_filter_column` is unset entirely, the legacy path is still used unchanged so existing dashboards keep working. Also took the opportunity to drop some unnecessary type casts flagged by the review bot on the dimension value (`string | number | boolean` flows through correctly without coercion). 257/257 tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
