alex-poor commented on PR #39906: URL: https://github.com/apache/superset/pull/39906#issuecomment-4475652210
@DamianPendrak coverage added in 588d8dd: - `Polygon/buildQuery.test.ts`: 3 new tests asserting `cross_filter_column` is added to query columns when set, deduped when overlapping with `js_columns`, and absent when unset. - `common.test.ts`: 4 new tests covering the rewritten cross-filter `onClick` branch under the deck.gl v9 event shape. Specifically: left click dispatches `setDataMask`; right click via `event.type='contextmenu'` dispatches `onContextMenu`; right click via `srcEvent.button=2` on a `type='click'` event also dispatches `onContextMenu`; and the regression guard — an event with no `leftButton`/`rightButton` fields (the v9 shape) still correctly dispatches. 264/264 tests pass; pre-commit clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
